Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Issue 2159103008: Default enable main frame before activation and remove finch experiment. (Closed)

Created:
4 years, 5 months ago by sunnyps
Modified:
4 years, 5 months ago
Reviewers:
rkaplow, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, brianderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Default enable main frame before activation and remove finch experiment. The finch experiment hasn't revealed any regressions other than in page load times which has been deemed a blink scheduler issue (see crbug.com/614482). R=piman@chromium.org,rkaplow@chromium.org BUG=612596 Committed: https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed Cr-Commit-Position: refs/heads/master@{#406916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -48 lines) Patch
M content/browser/gpu/compositor_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
sunnyps
PTAL
4 years, 5 months ago (2016-07-20 18:47:34 UTC) #2
piman
lgtm
4 years, 5 months ago (2016-07-20 22:27:18 UTC) #6
rkaplow
lgtm Can you please ensure you've cleaned up everything as per the wrap up section ...
4 years, 5 months ago (2016-07-21 18:30:09 UTC) #7
sunnyps
On 2016/07/21 18:30:09, rkaplow wrote: > lgtm > > Can you please ensure you've cleaned ...
4 years, 5 months ago (2016-07-21 18:32:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159103008/1
4 years, 5 months ago (2016-07-21 18:33:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 18:40:54 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed Cr-Commit-Position: refs/heads/master@{#406916}
4 years, 5 months ago (2016-07-21 18:42:55 UTC) #13
Ted C
4 years, 5 months ago (2016-07-22 00:53:54 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2170233002/ by tedchoc@chromium.org.

The reason for reverting is: Speculative revert for failing WebView tests on
Lollipop:

https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tes...
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Te...

Both phone and tablet started failing and this is the most "suspicious" change. 
boliu@ can help investigate further assuming this holds true..

Powered by Google App Engine
This is Rietveld 408576698