Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2159103007: Fix objdump assembly truncations (Closed)

Created:
4 years, 5 months ago by mattloring
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix objdump assembly truncations, d8 support Update the custom objdump script to handle inline comments starting with '--' or ';;'. Load d8 code.asm file if present. BUG= Committed: https://crrev.com/fb2feee6169adf984096c2fdd50ec6a5903e87e2 Cr-Commit-Position: refs/heads/master@{#37953}

Patch Set 1 #

Patch Set 2 : Add support for d8 code.asm #

Total comments: 1

Patch Set 3 : Prioritize process specific code.asm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M tools/objdump-v8 View 1 2 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
mattloring
4 years, 5 months ago (2016-07-20 18:29:32 UTC) #2
Benedikt Meurer
LGTM with comment. https://codereview.chromium.org/2159103007/diff/20001/tools/objdump-v8 File tools/objdump-v8 (right): https://codereview.chromium.org/2159103007/diff/20001/tools/objdump-v8#newcode62 tools/objdump-v8:62: codefile = open("code.asm", "r") I think ...
4 years, 5 months ago (2016-07-21 17:28:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159103007/40001
4 years, 5 months ago (2016-07-21 18:11:50 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-21 18:13:08 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 18:16:42 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fb2feee6169adf984096c2fdd50ec6a5903e87e2
Cr-Commit-Position: refs/heads/master@{#37953}

Powered by Google App Engine
This is Rietveld 408576698