Add policy provider that would filter extensions/apps allowed on the

chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "base/command_line.h"
 #include "base/files/dir_reader_posix.h"
 #include "base/files/file_path.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/path_service.h"
 #include "base/run_loop.h"
 #include "base/test/null_task_runner.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_process_platform_part.h"
+#include "chrome/browser/chromeos/extensions/signin_screen_policy_provider.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"
 #include "chrome/browser/chromeos/policy/device_policy_cros_browser_test.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
 #include "chrome/browser/policy/test/local_policy_test_server.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/chrome_constants.cc"
@@ skipping 98 matching lines @@
     BrowserPolicyConnectorChromeOS* connector =
         g_browser_process->platform_part()->browser_policy_connector_chromeos();
     connector->device_management_service()->ScheduleInitialization(0);
 
     ExtensionService* service =
         extensions::ExtensionSystem::Get(GetSigninProfile())
             ->extension_service();
     service->set_extensions_enabled(true);
   }
 
+  void TearDownOnMainThread() override {

[emaxx, 2016/11/11 16:11:37]

Is this actually needed?

[Denis Kuznetsov (DE-MUC), 2016/11/11 21:26:34]

Done.

+    DevicePolicyCrosBrowserTest::TearDownOnMainThread();
+  }
+
   static base::FilePath GetTestExtensionSourcePath() {
     base::FilePath test_data_dir;
     EXPECT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir));
     return test_data_dir.AppendASCII(kTestExtensionSourceDir);
   }
 
   static Profile* GetSigninProfile() {
     Profile* signin_profile =
         chromeos::ProfileHelper::GetSigninProfile()->GetOriginalProfile();
     EXPECT_TRUE(signin_profile);
@@ skipping 80 matching lines @@
   void SetUpCommandLine(base::CommandLine* command_line) override {
     SigninExtensionsDeviceCloudPolicyBrowserTestBase::SetUpCommandLine(
         command_line);
     command_line->AppendSwitchASCII(policy::switches::kDeviceManagementUrl,
                                     policy_test_server_.GetServiceURL().spec());
   }
 
   void SetUpInProcessBrowserTestFixture() override {
     SigninExtensionsDeviceCloudPolicyBrowserTestBase::
         SetUpInProcessBrowserTestFixture();
+    disabler_ =
+        base::MakeUnique<chromeos::ScopedSigninScreenPolicyProviderDisabler>();
     EXPECT_TRUE(PathService::Get(chromeos::DIR_SIGNIN_PROFILE_COMPONENT_POLICY,
                                  &component_policy_cache_dir_));
     PrepareFakeComponentPolicyResponse();
   }
 
   void TearDownInProcessBrowserTestFixture() override {
     // Check that the component policy cache was not cleared during browser
     // teardown.
     ResourceCache cache(component_policy_cache_dir_, new base::NullTaskRunner);
     std::string stub;
@@ skipping 20 matching lines @@
         BuildTestComponentPolicyPayload().SerializeAsString()));
     fetcher_factory_.SetFakeResponse(GURL(kFakePolicyUrl), kFakePolicy,
                                      net::HTTP_OK,
                                      net::URLRequestStatus::SUCCESS);
   }
 
   LocalPolicyTestServer policy_test_server_;
   net::URLFetcherImplFactory fetcher_impl_factory_;
   net::FakeURLFetcherFactory fetcher_factory_;
   base::FilePath component_policy_cache_dir_;
+  std::unique_ptr<chromeos::ScopedSigninScreenPolicyProviderDisabler> disabler_;

[emaxx, 2016/11/11 16:11:37]

Maybe change this member to have a more descriptive name?

[Denis Kuznetsov (DE-MUC), 2016/11/11 21:26:34]

Done.

 };
 
 IN_PROC_BROWSER_TEST_F(SigninExtensionsDeviceCloudPolicyBrowserTest,
                        InstallAndRunInWindow) {
   const extensions::Extension* extension = InstallAndLoadTestExtension();
   ASSERT_TRUE(extension);
   Browser* browser = CreateBrowser(GetSigninProfile());
   extensions::ResultCatcher result_catcher;
   ui_test_utils::NavigateToURL(
       browser, extension->GetResourceURL(kTestExtensionTestPage));
   EXPECT_TRUE(result_catcher.GetNextResult());
   CloseBrowserSynchronously(browser);
 }
 
 // This class tests that the cached component policy is successfully loaded and
 // passed to the extension that is already installed into the signin profile.
 //
 // To accomplish this, the class prefills the signin profile with, first, the
 // installed test extension, and, second, with the cached component policy.
 class PreinstalledSigninExtensionsDeviceCloudPolicyBrowserTest
     : public SigninExtensionsDeviceCloudPolicyBrowserTestBase {
  protected:
   constexpr static const char* kFakeProfileSourceDir =
       "extensions/profiles/signin_screen_managed_storage";
 
- private:
+  std::unique_ptr<chromeos::ScopedSigninScreenPolicyProviderDisabler> disabler_;
+
   bool SetUpUserDataDirectory() override {
     PrefillSigninProfile();
     PrefillComponentPolicyCache();
     return DevicePolicyCrosBrowserTest::SetUpUserDataDirectory();
   }
 
+  void SetUpInProcessBrowserTestFixture() override {
+    SigninExtensionsDeviceCloudPolicyBrowserTestBase::
+        SetUpInProcessBrowserTestFixture();
+    disabler_ =

[emaxx, 2016/11/11 16:11:37]

If both test subclasses need this disabler, then why not moving it into the
common base SigninExtensionsDeviceCloudPolicyBrowserTestBase? Also the disabler_
member could marked as private then.

[Denis Kuznetsov (DE-MUC), 2016/11/11 21:26:34]

Acknowledged.

+        base::MakeUnique<chromeos::ScopedSigninScreenPolicyProviderDisabler>();
+  }
+
   static void PrefillSigninProfile() {
     base::FilePath profile_source_path;
     EXPECT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &profile_source_path));
     profile_source_path = profile_source_path.AppendASCII(kFakeProfileSourceDir)
                               .AppendASCII(chrome::kInitialProfile);
 
     base::FilePath profile_target_path;
     EXPECT_TRUE(PathService::Get(chrome::DIR_USER_DATA, &profile_target_path));
 
     EXPECT_TRUE(
@@ skipping 31 matching lines @@
   ASSERT_TRUE(extension);
   Browser* browser = CreateBrowser(GetSigninProfile());
   extensions::ResultCatcher result_catcher;
   ui_test_utils::NavigateToURL(
       browser, extension->GetResourceURL(kTestExtensionTestPage));
   EXPECT_TRUE(result_catcher.GetNextResult());
   CloseBrowserSynchronously(browser);
 }
 
 }  // namespace policy