Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2159093002: Clear provisional item on all server redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add browser test. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/isolate-extensions ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index 832f73f5713e9abbf8b9749c400fdca055fd8399..4f18715f3c67995b26b2447aef9369419684d7cd 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -358,8 +358,8 @@ void FrameLoader::replaceDocumentWhileExecutingJavaScriptURL(const String& sourc
void FrameLoader::receivedMainResourceRedirect(const KURL& newURL)
{
client()->dispatchDidReceiveServerRedirectForProvisionalLoad();
- // If a back/forward navigation redirects cross-origin, don't reuse any state from the HistoryItem.
- if (m_provisionalItem && !SecurityOrigin::create(m_provisionalItem->url())->isSameSchemeHostPort(SecurityOrigin::create(newURL).get()))
Charlie Reis 2016/07/20 17:38:23 Nate, why was this restricted to cross-origin redi
+ // If a back/forward navigation redirects, don't reuse any state from the HistoryItem.
+ if (m_provisionalItem)
Nate Chapin 2016/07/20 17:42:27 Nit: the if() isn't really necessary here.
Charlie Reis 2016/07/20 18:03:22 Done.
m_provisionalItem.clear();
}
« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/isolate-extensions ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698