Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2159043002: Renamed Element::buildOwnLayout to Element::buildLayoutTree. (Closed)

Created:
4 years, 5 months ago by Bugs Nash
Modified:
4 years, 5 months ago
Reviewers:
esprehn, nainar, sashab
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed Element::buildOwnLayout to Element::buildLayoutTree. The method builds the entire sub-tree through Node::reattach, which calls Node::detach and Node::attach, which are overridden in ContainerNode to recurse through all the children in the tree. Committed: https://crrev.com/8cec599bf1a220736732f0c118008fcd49779443 Cr-Commit-Position: refs/heads/master@{#406223}

Patch Set 1 #

Patch Set 2 : Renamed Element::buildOwnLayout to Element::buildLayoutTree. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/Element.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
esprehn
lgtm
4 years, 5 months ago (2016-07-19 03:25:24 UTC) #6
sashab
lgtm
4 years, 5 months ago (2016-07-19 05:25:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159043002/20001
4 years, 5 months ago (2016-07-19 05:26:35 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 06:37:46 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 06:39:00 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8cec599bf1a220736732f0c118008fcd49779443
Cr-Commit-Position: refs/heads/master@{#406223}

Powered by Google App Engine
This is Rietveld 408576698