Source/web/WebInputElement.cpp - Issue 215903003: Autofill/rAc: dispatch "input" events when changing text contents of <textarea>,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebInputElement.cpp

Issue 215903003: Autofill/rAc: dispatch "input" events when changing text contents of <textarea>, (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add back dispatchFormControlChangeEvent() temporarily to not break chrome when blink gets rolled in Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebInputElement.cpp

diff --git a/Source/web/WebInputElement.cpp b/Source/web/WebInputElement.cpp

index e11deb62a2a81c85a9a965a5589ef9531d81bcab..58648d3836decf1592f4362479cdeb024266be24 100644

--- a/Source/web/WebInputElement.cpp

+++ b/Source/web/WebInputElement.cpp

@@ -107,9 +107,9 @@ bool WebInputElement::isValidValue(const WebString& value) const

return constUnwrap<HTMLInputElement>()->isValidValue(value);

}

-void WebInputElement::setChecked(bool nowChecked, bool sendChangeEvent)

+void WebInputElement::setChecked(bool nowChecked, bool sendEvents)

{

- unwrap<HTMLInputElement>()->setChecked(nowChecked, sendChangeEvent ? DispatchChangeEvent : DispatchNoEvent);

+ unwrap<HTMLInputElement>()->setChecked(nowChecked, sendEvents ? DispatchInputAndChangeEvent : DispatchNoEvent);

}

bool WebInputElement::isChecked() const

« Source/core/html/HTMLTextAreaElement.cpp ('K') | « Source/web/WebFormControlElement.cpp ('k') | public/web/WebFormControlElement.h » ('j') | no next file with comments »