Source/core/html/HTMLTextAreaElement.h - Issue 215903003: Autofill/rAc: dispatch "input" events when changing text contents of <textarea>,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextAreaElement.h

Issue 215903003: Autofill/rAc: dispatch "input" events when changing text contents of <textarea>, (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add back dispatchFormControlChangeEvent() temporarily to not break chrome when blink gets rolled in Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLTextAreaElement.h

diff --git a/Source/core/html/HTMLTextAreaElement.h b/Source/core/html/HTMLTextAreaElement.h

index 7d369ece6e5fde70959b7ab755352060b5151db6..ebc3f78d7d4d1ae46532598ef4b67c398b52bc84 100644

--- a/Source/core/html/HTMLTextAreaElement.h

+++ b/Source/core/html/HTMLTextAreaElement.h

@@ -42,7 +42,7 @@ public:

bool shouldWrapText() const { return m_wrap != NoWrap; }

virtual String value() const OVERRIDE;

- void setValue(const String&);

+ void setValue(const String&, TextFieldEventBehavior = DispatchNoEvent);

String defaultValue() const;

void setDefaultValue(const String&);

int textLength() const { return value().length(); }

@@ -75,7 +75,7 @@ private:

static String sanitizeUserInputValue(const String&, unsigned maxLength);

void updateValue() const;

void setNonDirtyValue(const String&);

- void setValueCommon(const String&);

+ void setValueCommon(const String&, TextFieldEventBehavior);

virtual bool supportsPlaceholder() const OVERRIDE { return true; }

virtual void updatePlaceholderText() OVERRIDE;

« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/html/HTMLTextAreaElement.cpp » ('j') | Source/core/html/HTMLTextAreaElement.cpp » ('J')