Source/core/html/HTMLSelectElement.h - Issue 215903003: Autofill/rAc: dispatch "input" events when changing text contents of <textarea>,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.h

Issue 215903003: Autofill/rAc: dispatch "input" events when changing text contents of <textarea>, (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add back dispatchFormControlChangeEvent() temporarily to not break chrome when blink gets rolled in Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSelectElement.h

diff --git a/Source/core/html/HTMLSelectElement.h b/Source/core/html/HTMLSelectElement.h

index 8268cc15a8c3508e851f1278dbdbc0c98d14753c..bdbc3c4003562eca25cc66c6d7b1cbb793bcb721 100644

--- a/Source/core/html/HTMLSelectElement.h

+++ b/Source/core/html/HTMLSelectElement.h

@@ -68,7 +68,7 @@ public:

void remove(int index);

String value() const;

- void setValue(const String&);

+ void setValue(const String&, bool sendEvents = false);

String suggestedValue() const;

void setSuggestedValue(const String&);

@@ -144,7 +144,7 @@ private:

virtual void defaultEventHandler(Event*) OVERRIDE;

- void dispatchInputAndChangeEventForMenuList();

+ void dispatchInputAndChangeEventForMenuList(bool requiresUserGesture = true);

void recalcListItems(bool updateSelectedStates = true) const;

« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | Source/core/html/HTMLTextAreaElement.cpp » ('J')