Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2159023002: [Findit] Catch ValueError when get swarming result. (Closed)

Created:
4 years, 5 months ago by chanli
Modified:
4 years, 5 months ago
Reviewers:
stgao, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Catch ValueError when get swarming result. BUG=629182 Committed: https://chromium.googlesource.com/infra/infra/+/3f720ae2f5fe8682b871147f0f8ac2a976d45bc6

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M appengine/findit/model/wf_analysis.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M appengine/findit/waterfall/swarming_util.py View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
chanli
This is a very small change. PTAL
4 years, 5 months ago (2016-07-18 22:00:07 UTC) #2
stgao
lgtm
4 years, 5 months ago (2016-07-19 03:47:49 UTC) #3
lijeffrey
https://codereview.chromium.org/2159023002/diff/1/appengine/findit/waterfall/swarming_util.py File appengine/findit/waterfall/swarming_util.py (right): https://codereview.chromium.org/2159023002/diff/1/appengine/findit/waterfall/swarming_util.py#newcode258 appengine/findit/waterfall/swarming_util.py:258: return None Do we want to add some logging ...
4 years, 5 months ago (2016-07-19 04:43:43 UTC) #4
chanli
https://codereview.chromium.org/2159023002/diff/1/appengine/findit/waterfall/swarming_util.py File appengine/findit/waterfall/swarming_util.py (right): https://codereview.chromium.org/2159023002/diff/1/appengine/findit/waterfall/swarming_util.py#newcode258 appengine/findit/waterfall/swarming_util.py:258: return None On 2016/07/19 04:43:43, lijeffrey wrote: > Do ...
4 years, 5 months ago (2016-07-20 20:12:33 UTC) #5
lijeffrey
lgtm
4 years, 5 months ago (2016-07-23 00:19:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159023002/20001
4 years, 5 months ago (2016-07-23 00:19:55 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 00:39:12 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/3f720ae2f5fe8682b871147f0f8ac...

Powered by Google App Engine
This is Rietveld 408576698