Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: chrome/browser/metrics/leak_detector/leak_detector_controller.h

Issue 2159013002: Read Chrome build ID and store it in leak reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove DCHECK for build ID having been read Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/leak_detector/leak_detector_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_CONTROLLER_H_
6 #define CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_CONTROLLER_H_ 6 #define CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_CONTROLLER_H_
7 7
8 #include <stdint.h>
9
8 #include <vector> 10 #include <vector>
9 11
10 #include "base/macros.h" 12 #include "base/macros.h"
11 #include "base/threading/thread_checker.h" 13 #include "base/threading/thread_checker.h"
12 #include "chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h " 14 #include "chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h "
13 #include "components/metrics/leak_detector/leak_detector.h" 15 #include "components/metrics/leak_detector/leak_detector.h"
14 #include "components/metrics/proto/memory_leak_report.pb.h" 16 #include "components/metrics/proto/memory_leak_report.pb.h"
15 17
16 namespace metrics { 18 namespace metrics {
17 19
(...skipping 28 matching lines...) Expand all
46 MemoryLeakReportProto::ProcessType process_type); 48 MemoryLeakReportProto::ProcessType process_type);
47 49
48 // All leak reports received through OnLeakFound() are stored in protobuf 50 // All leak reports received through OnLeakFound() are stored in protobuf
49 // format. 51 // format.
50 std::vector<MemoryLeakReportProto> stored_reports_; 52 std::vector<MemoryLeakReportProto> stored_reports_;
51 53
52 // Contains all the parameters passed to LeakDetector. Store them in a single 54 // Contains all the parameters passed to LeakDetector. Store them in a single
53 // protobuf message instead of in separate member variables. 55 // protobuf message instead of in separate member variables.
54 const MemoryLeakReportProto::Params params_; 56 const MemoryLeakReportProto::Params params_;
55 57
58 // The build ID of the current Chrome binary.
59 std::vector<uint8_t> build_id_;
60
56 // For thread safety. 61 // For thread safety.
57 base::ThreadChecker thread_checker_; 62 base::ThreadChecker thread_checker_;
58 63
59 DISALLOW_COPY_AND_ASSIGN(LeakDetectorController); 64 DISALLOW_COPY_AND_ASSIGN(LeakDetectorController);
60 }; 65 };
61 66
62 } // namespace metrics 67 } // namespace metrics
63 68
64 #endif // CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_CONTROLLER_H_ 69 #endif // CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_CONTROLLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/metrics/leak_detector/leak_detector_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698