Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: build/config/v8_target_cpu.gni

Issue 2159003002: Fix the v8 snapshots in the GN mipsel, mips64el builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add mips64el as well Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/toolchain/linux/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni") 5 import("//build/config/sanitizers/sanitizers.gni")
6 6
7 declare_args() { 7 declare_args() {
8 # This arg is used when we want to tell the JIT-generating v8 code 8 # This arg is used when we want to tell the JIT-generating v8 code
9 # that we want to have it generate for an architecture that is different 9 # that we want to have it generate for an architecture that is different
10 # than the architecture that v8 will actually run on; we then run the 10 # than the architecture that v8 will actually run on; we then run the
(...skipping 16 matching lines...) Expand all
27 # 27 #
28 # v8_target_cpu can only be used to target one architecture in a build, 28 # v8_target_cpu can only be used to target one architecture in a build,
29 # so if you wish to build multiple copies of v8 that are targetting 29 # so if you wish to build multiple copies of v8 that are targetting
30 # different architectures, you will need to do something more 30 # different architectures, you will need to do something more
31 # complicated involving multiple toolchains along the lines of 31 # complicated involving multiple toolchains along the lines of
32 # custom_toolchain, above. 32 # custom_toolchain, above.
33 v8_target_cpu = "" 33 v8_target_cpu = ""
34 } 34 }
35 35
36 if (v8_target_cpu == "") { 36 if (v8_target_cpu == "") {
37 if (current_toolchain == "//build/toolchain/linux:clang_x64_v8_arm64" || 37 if (current_toolchain == "//build/toolchain/linux:clang_x64_v8_arm64") {
38 current_toolchain == "//build/toolchain/linux:x64_v8_arm64") {
39 v8_target_cpu = "arm64" 38 v8_target_cpu = "arm64"
40 } else if (current_toolchain == "//build/toolchain/linux:clang_x86_v8_arm" || 39 } else if (current_toolchain == "//build/toolchain/linux:clang_x86_v8_arm") {
41 current_toolchain == "//build/toolchain/linux:x86_v8_arm") {
42 v8_target_cpu = "arm" 40 v8_target_cpu = "arm"
41 } else if (current_toolchain ==
42 "//build/toolchain/linux:clang_x86_v8_mips64el") {
43 v8_target_cpu = "mips64el"
44 } else if (current_toolchain ==
45 "//build/toolchain/linux:clang_x86_v8_mipsel") {
46 v8_target_cpu = "mipsel"
43 } else if (is_msan) { 47 } else if (is_msan) {
44 # If we're running under a sanitizer, if we configure v8 to generate 48 # If we're running under a sanitizer, if we configure v8 to generate
45 # code that will be run under a simulator, then the generated code 49 # code that will be run under a simulator, then the generated code
46 # also gets the benefits of the sanitizer. 50 # also gets the benefits of the sanitizer.
47 v8_target_cpu = "arm64" 51 v8_target_cpu = "arm64"
48 } else { 52 } else {
49 v8_target_cpu = target_cpu 53 v8_target_cpu = target_cpu
50 } 54 }
51 } 55 }
52 56
53 declare_args() { 57 declare_args() {
54 # This argument is declared here so that it can be overridden in toolchains. 58 # This argument is declared here so that it can be overridden in toolchains.
55 # It should never be explicitly set by the user. 59 # It should never be explicitly set by the user.
56 v8_current_cpu = v8_target_cpu 60 v8_current_cpu = v8_target_cpu
57 } 61 }
OLDNEW
« no previous file with comments | « no previous file | build/toolchain/linux/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698