Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2158973003: Fixes for updating synthetic element offsets. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -10 lines) Patch
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 4 chunks +12 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 7 chunks +64 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-07-18 22:20:31 UTC) #1
Brian Wilkerson
lgtm
4 years, 5 months ago (2016-07-18 23:23:53 UTC) #2
scheglov
4 years, 5 months ago (2016-07-19 00:39:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c2dc61ffa55d06fead231e984f4381dead4a82f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698