Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4100)

Unified Diff: cc/trees/threaded_channel.cc

Issue 2158973002: cc: Clean up LayerTreeTest and TestHooks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: proxy-impls: test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/threaded_channel.h ('k') | cc/trees/threaded_channel_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/threaded_channel.cc
diff --git a/cc/trees/threaded_channel.cc b/cc/trees/threaded_channel.cc
index 3f18b23cbd2cd71ea75bdb5ac76b663c7cab6b34..ab0fa28e333e98e468ead3f356681b68ddee2fdb 100644
--- a/cc/trees/threaded_channel.cc
+++ b/cc/trees/threaded_channel.cc
@@ -139,15 +139,17 @@ void ThreadedChannel::MainFrameWillHappenOnImplForTesting(
proxy_impl_weak_ptr_, completion, main_frame_will_happen));
}
-void ThreadedChannel::StartCommitOnImpl(CompletionEvent* completion,
- LayerTreeHost* layer_tree_host,
- base::TimeTicks main_thread_start_time,
- bool hold_commit_for_activation) {
+void ThreadedChannel::NotifyReadyToCommitOnImpl(
+ CompletionEvent* completion,
+ LayerTreeHost* layer_tree_host,
+ base::TimeTicks main_thread_start_time,
+ bool hold_commit_for_activation) {
DCHECK(IsMainThread());
ImplThreadTaskRunner()->PostTask(
- FROM_HERE, base::Bind(&ProxyImpl::StartCommitOnImpl, proxy_impl_weak_ptr_,
- completion, layer_tree_host, main_thread_start_time,
- hold_commit_for_activation));
+ FROM_HERE,
+ base::Bind(&ProxyImpl::NotifyReadyToCommitOnImpl, proxy_impl_weak_ptr_,
+ completion, layer_tree_host, main_thread_start_time,
+ hold_commit_for_activation));
}
void ThreadedChannel::SynchronouslyInitializeImpl(
@@ -278,8 +280,9 @@ std::unique_ptr<ProxyImpl> ThreadedChannel::CreateProxyImpl(
TaskRunnerProvider* task_runner_provider,
std::unique_ptr<BeginFrameSource> external_begin_frame_source) {
DCHECK(IsImplThread());
- return ProxyImpl::Create(channel_impl, layer_tree_host, task_runner_provider,
- std::move(external_begin_frame_source));
+ return base::MakeUnique<ProxyImpl>(channel_impl, layer_tree_host,
+ task_runner_provider,
+ std::move(external_begin_frame_source));
}
void ThreadedChannel::InitializeImplOnImpl(
« no previous file with comments | « cc/trees/threaded_channel.h ('k') | cc/trees/threaded_channel_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698