Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2158953002: swarmbucket: add $project template parameter (Closed)

Created:
4 years, 5 months ago by nodir
Modified:
4 years, 5 months ago
Reviewers:
dnj, dnj (Google)
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

swarmbucket: add $project template parameter swarmbucket-logdog integration needs luci project that logdog will stream logs to. Add $project parameter derived from the project that desfines the bucket. R=dnj@chromium.org BUG=628321 Committed: https://chromium.googlesource.com/infra/infra/+/f193920d9653cbafe1eb653a8b4bcc6a931334be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M appengine/cr-buildbucket/acl.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/cr-buildbucket/config.py View 1 chunk +4 lines, -3 lines 0 comments Download
M appengine/cr-buildbucket/swarming/swarming.py View 5 chunks +6 lines, -4 lines 0 comments Download
M appengine/cr-buildbucket/swarming/test/swarming_test.py View 4 chunks +7 lines, -4 lines 0 comments Download
M appengine/cr-buildbucket/test/acl_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/cr-buildbucket/test/config_test.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nodir
PTAL
4 years, 5 months ago (2016-07-18 17:04:12 UTC) #1
dnj (Google)
lgtm. Do we maybe want to clarify that this is a "LUCI Project" (e.g., "luci_project"), ...
4 years, 5 months ago (2016-07-18 17:05:43 UTC) #3
nodir
On 2016/07/18 17:05:43, dnj (Google) wrote: > lgtm. Do we maybe want to clarify that ...
4 years, 5 months ago (2016-07-18 17:11:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158953002/1
4 years, 5 months ago (2016-07-18 17:11:21 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 18:13:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/f193920d9653cbafe1eb653a8b4bc...

Powered by Google App Engine
This is Rietveld 408576698