sdk/lib/core/uri.dart - Issue 2158933003: Fix for uri replace whene uri has fragment. Was adding a second '#'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/core/uri.dart

Issue 2158933003: Fix for uri replace whene uri has fragment. Was adding a second '#'. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/core/uri.dart

diff --git a/sdk/lib/core/uri.dart b/sdk/lib/core/uri.dart

index 17f290d14e9be14108050c037aac48ff94348329..ba3d001633dc3579c0eef58425c71cbba2220814 100644

--- a/sdk/lib/core/uri.dart

+++ b/sdk/lib/core/uri.dart

@@ -4207,7 +4207,7 @@ class _SimpleUri implements Uri {

if (fragment != null) {

fragment = _Uri._makeFragment(fragment, 0, fragment.length);

} else if (_fragmentStart < _uri.length) {

- fragment = _uri.substring(_fragmentStart);

+ fragment = _uri.substring(_fragmentStart+1);

Harry Terkelsen 2016/07/18 22:48:12 nit: spaces around '+'

keertip 2016/07/18 23:29:32 Done.

}

return new _Uri._internal(

« no previous file with comments | « no previous file | tests/corelib/uri_test.dart » ('j') | tests/corelib/uri_test.dart » ('J')