Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 215893005: Add API for adding and removing CallCompletedCallbacks to Isolate (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Sven Panne, dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add API for adding and removing CallCompletedCallbacks to Isolate The API currently just forwards to the global methods. A follow-up change will move the callback handling to the Isolate and deprecate the global versions. BUG= R=dcarney@chromium.org, svenpanne@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=20463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M include/v8.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
ptal
6 years, 8 months ago (2014-04-03 06:57:41 UTC) #1
dcarney
lgtm
6 years, 8 months ago (2014-04-03 07:38:44 UTC) #2
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-03 07:51:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20463 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698