Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 215893003: [Ozone] Get VSyncProvider before passing in the scoped_ptr (Closed)

Created:
6 years, 8 months ago by dnicoara
Modified:
6 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Visibility:
Public.

Description

[Ozone] Get VSyncProvider before passing in the scoped_ptr NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261362

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/gl/gl_surface_ozone.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
dnicoara
PTAL
6 years, 8 months ago (2014-04-02 17:11:38 UTC) #1
piman
LGTM
6 years, 8 months ago (2014-04-02 19:57:25 UTC) #2
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 8 months ago (2014-04-02 19:58:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/215893003/1
6 years, 8 months ago (2014-04-02 19:59:42 UTC) #4
dnicoara
The CQ bit was unchecked by dnicoara@chromium.org
6 years, 8 months ago (2014-04-03 00:22:43 UTC) #5
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 8 months ago (2014-04-03 00:22:46 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:04:37 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:04:38 UTC) #8
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 8 months ago (2014-04-03 12:07:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/215893003/1
6 years, 8 months ago (2014-04-03 12:07:22 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 12:08:14 UTC) #11
Message was sent while issue was closed.
Change committed as 261362

Powered by Google App Engine
This is Rietveld 408576698