Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2158923002: [x64] fixed "vmovups reg, mem" (Closed)

Created:
4 years, 5 months ago by Weiliang
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] fixed "vmovups reg, mem" BUG= Committed: https://crrev.com/2e6628c487096ec721ac0d921ada08607b1648a0 Cr-Commit-Position: refs/heads/master@{#37846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -11 lines) Patch
M src/x64/assembler-x64.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +1 line, -8 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Weiliang
PTAL
4 years, 5 months ago (2016-07-18 16:33:55 UTC) #2
bbudge
lgtm Thanks for fixing this! We will add you to any future assembler CLs.
4 years, 5 months ago (2016-07-18 17:49:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158923002/1
4 years, 5 months ago (2016-07-19 02:37:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 03:12:42 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 03:14:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e6628c487096ec721ac0d921ada08607b1648a0
Cr-Commit-Position: refs/heads/master@{#37846}

Powered by Google App Engine
This is Rietveld 408576698