src/parsing/preparser.h - Issue 2158913005: Introduce NewScriptScope that creates a top-level scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/preparser.h

Issue 2158913005: Introduce NewScriptScope that creates a top-level scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/preparser.h

diff --git a/src/parsing/preparser.h b/src/parsing/preparser.h

index 1c4c22741d14373e6aab935e8cab094be52048d0..3b2f503b62fa71cf76d8925b583af0c748ccbf42 100644

--- a/src/parsing/preparser.h

+++ b/src/parsing/preparser.h

@@ -1038,7 +1038,7 @@ class PreParser : public ParserBase<PreParserTraits> {

PreParseResult PreParseProgram(int* materialized_literals = 0,

bool is_module = false) {

DCHECK_NULL(scope_state_);

- Scope* scope = NewScope(nullptr, SCRIPT_SCOPE);

+ Scope* scope = NewScriptScope();

// ModuleDeclarationInstantiation for Source Text Module Records creates a

// new Module Environment Record whose outer lexical environment record is

« no previous file with comments | « src/parsing/parser-base.h ('k') | src/parsing/preparser.cc » ('j') | no next file with comments »