Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2158913005: Introduce NewScriptScope that creates a top-level scope (Closed)

Created:
4 years, 5 months ago by Toon Verwaest
Modified:
4 years, 5 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce NewScriptScope that creates a top-level scope It's the only Scope type that has outer scope nullptr; and it always has outer scope nullptr. BUG=v8:5209 Committed: https://crrev.com/d6a38645eff128562a302b885164199292a7dce0 Cr-Commit-Position: refs/heads/master@{#37907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M src/parsing/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +9 lines, -2 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/preparser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
4 years, 5 months ago (2016-07-20 08:30:14 UTC) #2
marja
lgtm
4 years, 5 months ago (2016-07-20 08:51:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158913005/1
4 years, 5 months ago (2016-07-20 11:14:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/5339)
4 years, 5 months ago (2016-07-20 11:16:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158913005/1
4 years, 5 months ago (2016-07-20 12:24:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 12:54:45 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 12:56:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6a38645eff128562a302b885164199292a7dce0
Cr-Commit-Position: refs/heads/master@{#37907}

Powered by Google App Engine
This is Rietveld 408576698