chrome/browser/android/data_usage/data_use_tab_model_unittest.cc - Issue 2158913002: Make DataUseTabModel and DataUseMatcher more independent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/data_usage/data_use_tab_model_unittest.cc

Issue 2158913002: Make DataUseTabModel and DataUseMatcher more independent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: minor fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/data_usage/data_use_tab_model.cc ('k') | chrome/browser/android/data_usage/data_use_ui_tab_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/data_usage/data_use_tab_model_unittest.cc

diff --git a/chrome/browser/android/data_usage/data_use_tab_model_unittest.cc b/chrome/browser/android/data_usage/data_use_tab_model_unittest.cc

index a3c435cdc909f0a0aaed82ba72d3c47d6d169837..3ae808e6b8ad4b3194df41044c649c918d8afecf 100644

--- a/chrome/browser/android/data_usage/data_use_tab_model_unittest.cc

+++ b/chrome/browser/android/data_usage/data_use_tab_model_unittest.cc

@@ -9,6 +9,8 @@

#include <memory>

#include <string>

+#include "base/bind.h"

+#include "base/bind_helpers.h"

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

#include "base/message_loop/message_loop.h"

@@ -115,9 +117,12 @@ class DataUseTabModelTest : public testing::Test {

protected:

void SetUp() override {

base::RunLoop().RunUntilIdle();

- data_use_tab_model_.reset(new DataUseTabModel());

- data_use_tab_model_->InitOnUIThread(

- external_data_use_observer_bridge_.get());

+ data_use_tab_model_.reset(new DataUseTabModel(

+ base::Bind(&ExternalDataUseObserverBridge::FetchMatchingRules,

+ base::Unretained(external_data_use_observer_bridge_.get())),

+ base::Bind(

+ &ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver,

+ base::Unretained(external_data_use_observer_bridge_.get()))));

tick_clock_ = new base::SimpleTestTickClock();