Make DataUseTabModel and DataUseMatcher more independent

chrome/browser/android/data_usage/data_use_matcher.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_DATA_USAGE_DATA_USE_MATCHER_H_
 #define CHROME_BROWSER_ANDROID_DATA_USAGE_DATA_USE_MATCHER_H_
 
 #include <memory>
 #include <string>
 #include <vector>
 
+#include "base/callback_forward.h"
 #include "base/compiler_specific.h"
 #include "base/containers/hash_tables.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/threading/thread_checker.h"
 #include "base/time/time.h"
-#include "chrome/browser/android/data_usage/data_use_tab_model.h"
-
 namespace base {
 class TickClock;
 }
 
 namespace re2 {
 class RE2;
 }
 
 class GURL;
 
 namespace chrome {
 
 namespace android {
 
-class ExternalDataUseObserverBridge;
-
 // DataUseMatcher stores the matching URL patterns and package names along with
 // the labels. It also provides functionality to get the matching label for a
 // given URL or package. DataUseMatcher is not thread safe.
 class DataUseMatcher {
  public:
   DataUseMatcher(

[tbansal1, 2016/07/18 17:04:38]

add comments about the callback.

[Raj, 2016/07/19 00:19:02]

Done.

-      const base::WeakPtr<DataUseTabModel>& data_use_tab_model,
-      const ExternalDataUseObserverBridge* external_data_use_observer_bridge,
+      const base::Callback<void(const std::string&)>&
+          on_tracking_label_removed_callback,
+      const base::Callback<void(bool)>& on_matching_rules_fetched_callback,
       const base::TimeDelta& default_matching_rule_expiration_duration);
 
   ~DataUseMatcher();
 
   // Called by FetchMatchingRulesDoneOnIOThread to register multiple
   // case-insensitive regular expressions. If the url of the data use request
   // matches any of the regular expression, the observation is passed to the
   // Java listener.
   void RegisterURLRegexes(const std::vector<std::string>& app_package_names,
                           const std::vector<std::string>& domain_path_regexes,
                           const std::vector<std::string>& labels);
 
   // Returns true if the |url| matches the registered regular expressions.
   // |label| must not be null. If a match is found, the |label| is set to the
   // matching rule's label.
   bool MatchesURL(const GURL& url, std::string* label) const WARN_UNUSED_RESULT;
 
   // Returns true if the |app_package_name| matches the registered package
   // names. |label| must not be null. If a match is found, the |label| is set
   // to the matching rule's label.
   bool MatchesAppPackageName(const std::string& app_package_name,
                              std::string* label) const WARN_UNUSED_RESULT;
 
-  // Fetches the matching rules asynchronously from
-  // |external_data_use_observer_bridge_|.
-  void FetchMatchingRules();
-
   // Returns true if there is any matching rule. HasRules may return true even
   // if all rules are expired.
   bool HasRules() const;
 
   // Returns true if there is any valid matching rule with label |label|.
   bool HasValidRuleWithLabel(const std::string& label) const;
 
  private:
   friend class DataUseMatcherTest;
   FRIEND_TEST_ALL_PREFIXES(DataUseMatcherTest,
@@ skipping 41 matching lines @@
   // expected format, |expiration| will be set to default expiration duration
   // from now, and |new_app_package_name| will be set to the |app_package_name|.
   void ParsePackageField(const std::string& app_package_name,
                          std::string* new_app_package_name,
                          base::TimeTicks* expiration) const;
 
   base::ThreadChecker thread_checker_;
 
   std::vector<std::unique_ptr<MatchingRule>> matching_rules_;
 
-  // |data_use_tab_model_| is notified if a label is removed from the set of
-  // matching labels.
-  base::WeakPtr<DataUseTabModel> data_use_tab_model_;
-
   // Default expiration duration of a matching rule, if expiration is not
   // specified in the rule.
   const base::TimeDelta default_matching_rule_expiration_duration_;
 
   // TickClock used for obtaining the current time.
   std::unique_ptr<base::TickClock> tick_clock_;
 
-  // Pointer to the ExternalDataUseObserverBridge owned by
-  // ExternalDataUseObserver. DataUseTabModel (owner of |this|) and
-  // ExternalDataUseObserverBridge are owned by ExternalDataUseObserver, and are
-  // destroyed in that order. So |external_data_use_observer_bridge_| is
-  // guaranteed to be non-null.
-  const ExternalDataUseObserverBridge* external_data_use_observer_bridge_;
+  // Callback to be run when a label is removed from the set of matching labels.
+  const base::Callback<void(const std::string&)>&
+      on_tracking_label_removed_callback_;
+
+  // Callback to be run when matching rules are fetched.
+  const base::Callback<void(bool)>& on_matching_rules_fetched_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(DataUseMatcher);
 };
 
 }  // namespace android
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_ANDROID_DATA_USAGE_DATA_USE_MATCHER_H_