Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2158893002: Fix data race in IPC::ChannelProxy (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix data race in IPC::ChannelProxy Fixes a missing lock acquisition from the listener thread when accessing |channel_|. Also removes the TSAN suppression for this bug. BUG=628481 TBR=glider@chromium.org for suppression removal Committed: https://crrev.com/078a84e8624eb27e3497bf86ae905550da8acc2d Cr-Commit-Position: refs/heads/master@{#406033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Ken Rockot(use gerrit already)
4 years, 5 months ago (2016-07-18 15:53:20 UTC) #4
jam
lgtm
4 years, 5 months ago (2016-07-18 17:54:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158893002/1
4 years, 5 months ago (2016-07-18 17:55:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 18:05:47 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/078a84e8624eb27e3497bf86ae905550da8acc2d Cr-Commit-Position: refs/heads/master@{#406033}
4 years, 5 months ago (2016-07-18 18:07:56 UTC) #13
Alexander Potapenko
4 years, 5 months ago (2016-07-18 18:22:59 UTC) #14
Message was sent while issue was closed.
On 2016/07/18 18:07:56, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/078a84e8624eb27e3497bf86ae905550da8acc2d
> Cr-Commit-Position: refs/heads/master@{#406033}

LGTM

Powered by Google App Engine
This is Rietveld 408576698