chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java - Issue 2158883002: Change NTPSnippetsBridge to read from ContentSuggestionsService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

Issue 2158883002: Change NTPSnippetsBridge to read from ContentSuggestionsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offlinepagesprovider

Patch Set: Marc's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java ('k') | chrome/browser/android/ntp/ntp_snippets_bridge.h » ('j') | chrome/browser/android/ntp/ntp_snippets_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

index 048b85e22a44cd0fb7ceff98b601ba594d9ac8a9..4b4c79926155b83c0e05a59a5a541d5e3b5b0b27 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

@@ -12,7 +12,7 @@ import static org.mockito.Mockito.mock;

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.base.test.util.Feature;

import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;

-import org.chromium.chrome.browser.ntp.snippets.DisabledReason;

+import org.chromium.chrome.browser.ntp.snippets.ContentSuggestionsCategoryStatus;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;

import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge.SnippetsObserver;

@@ -133,7 +133,7 @@ public class NewTabPageAdapterTest {

assertEquals(3 + snippets.size(), ntpa.getItemCount());

// When we clear the snippets, we should go back to the situation with the status card.

- mSnippetsObserver.onDisabledReasonChanged(DisabledReason.NONE);

+ mSnippetsObserver.onCategoryStatusChanged(ContentSuggestionsCategoryStatus.AVAILABLE);

assertEquals(4, ntpa.getItemCount());

// The adapter should now be waiting for new snippets.