components/ntp_snippets/BUILD.gn - Issue 2158883002: Change NTPSnippetsBridge to read from ContentSuggestionsService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/BUILD.gn

Issue 2158883002: Change NTPSnippetsBridge to read from ContentSuggestionsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offlinepagesprovider

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java ('K') | « chrome/browser/android/ntp/ntp_snippets_bridge.cc ('k') | components/ntp_snippets/content_suggestions_provider.h » ('j') | components/ntp_snippets/content_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/BUILD.gn

diff --git a/components/ntp_snippets/BUILD.gn b/components/ntp_snippets/BUILD.gn

index 29853dda7ef252b0d91f06f5d72755f5f0b10e6a..5c0014e27b3744b3bec1d31a29aff017677702b7 100644

--- a/components/ntp_snippets/BUILD.gn

+++ b/components/ntp_snippets/BUILD.gn

@@ -70,6 +70,7 @@ source_set("ntp_snippets") {

if (is_android) {

java_cpp_enum("ntp_snippets_java_enums_srcjar") {

sources = [

+ "content_suggestions_category_status.h",

"ntp_snippets_status_service.h",

Marc Treib 2016/07/19 09:30:24 Is this still needed?

Philipp Keck 2016/07/19 13:53:23 No, I removed it along with the comment on the enu

]

}