Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Side by Side Diff: components/ntp_snippets/request_throttler_unittest.cc

Issue 2158843002: Introduce a request throttler for limiting requests in mobile NTP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tim's comments (renaming) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/ntp_snippets/request_throttler.h"
6
7 #include <memory>
8
9 #include "base/strings/stringprintf.h"
10 #include "components/ntp_snippets/pref_names.h"
11 #include "components/prefs/pref_registry_simple.h"
12 #include "components/prefs/testing_pref_service.h"
13 #include "testing/gtest/include/gtest/gtest.h"
14
15 namespace {
16 const int kCounterQuota = 2;
17 } // namespace
18
19 namespace ntp_snippets {
20
21 class RequestThrottlerTest : public testing::Test {
22 public:
23 RequestThrottlerTest() {
24 RequestThrottler::RegisterProfilePrefs(test_prefs_.registry());
25 // Use any arbitrary RequestType for this unittest.
26 throttler_.reset(new RequestThrottler(
27 &test_prefs_, RequestThrottler::RequestType::CONTENT_SUGGESTION_FETCHER,
28 kCounterQuota));
29 }
30
31 protected:
32 TestingPrefServiceSimple test_prefs_;
33 std::unique_ptr<RequestThrottler> throttler_;
34
35 private:
36 DISALLOW_COPY_AND_ASSIGN(RequestThrottlerTest);
37 };
38
39 TEST_F(RequestThrottlerTest, QuotaExceeded) {
40 EXPECT_TRUE(throttler_->DemandQuotaForRequest(false));
41 EXPECT_TRUE(throttler_->DemandQuotaForRequest(false));
42 EXPECT_FALSE(throttler_->DemandQuotaForRequest(false));
43 }
44
45 TEST_F(RequestThrottlerTest, ForcedDoesNotCountInQuota) {
46 EXPECT_TRUE(throttler_->DemandQuotaForRequest(false));
47 EXPECT_TRUE(throttler_->DemandQuotaForRequest(true));
48 EXPECT_TRUE(throttler_->DemandQuotaForRequest(false));
49 }
50
51 TEST_F(RequestThrottlerTest, ForcedWorksRegardlessOfQuota) {
52 EXPECT_TRUE(throttler_->DemandQuotaForRequest(false));
53 EXPECT_TRUE(throttler_->DemandQuotaForRequest(false));
54 EXPECT_TRUE(throttler_->DemandQuotaForRequest(true));
55 }
56
57 TEST_F(RequestThrottlerTest, QuotaIsPerDay) {
58 EXPECT_TRUE(throttler_->DemandQuotaForRequest(false));
59 EXPECT_TRUE(throttler_->DemandQuotaForRequest(false));
60
61 // Now fake the day pref so that the counter believes the count comes from
62 // yesterday.
63 int now_day = (base::Time::Now() - base::Time::UnixEpoch()).InDays();
64 test_prefs_.SetInteger(ntp_snippets::prefs::kSnippetFetcherQuotaDay,
65 now_day - 1);
66
67 // The quota should get reset as the day has changed.
68 EXPECT_TRUE(throttler_->DemandQuotaForRequest(false));
69 }
70
71 } // namespace ntp_snippets
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698