components/ntp_snippets/pref_names.h - Issue 2158843002: Introduce a request throttler for limiting requests in mobile NTP.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_snippets/pref_names.h

Issue 2158843002: Introduce a request throttler for limiting requests in mobile NTP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix to compile unittests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_NTP_SNIPPETS_PREF_NAMES_H_	5 #ifndef COMPONENTS_NTP_SNIPPETS_PREF_NAMES_H_

6 #define COMPONENTS_NTP_SNIPPETS_PREF_NAMES_H_	6 #define COMPONENTS_NTP_SNIPPETS_PREF_NAMES_H_

7	7

8 namespace ntp_snippets {	8 namespace ntp_snippets {

9 namespace prefs {	9 namespace prefs {

10	10

11 extern const char kEnableSnippets[];	11 extern const char kEnableSnippets[];

12	12

13 extern const char kSnippetHosts[];	13 extern const char kSnippetHosts[];

14	14

	15 // Current day for counting NTPSnippetsFetcher requests.

	16 extern const char kSnippetFetcherQuotaDay[];

	17 // The count of NTPSnippetsFetcher requests for today, so far.
	tschumann 2016/07/21 11:37:09 sorry for being nit-picky: But this constant is a sorry for being nit-picky: But this constant is a name not a count :-) Would you mind updating the comment like: // The pref-name for the NTPSnippetsFetcher requests for today counter. [i'm unsure if i'm using proper terminology though] Marc Treib 2016/07/21 11:43:50 I think it's fairly common to have this type of co Show quoted text On 2016/07/21 11:37:09, tschumann wrote: > sorry for being nit-picky: But this constant is a name not a count :-) Would you > mind updating the comment like: > // The pref-name for the NTPSnippetsFetcher requests for today counter. > > [i'm unsure if i'm using proper terminology though] I think it's fairly common to have this type of comment on pref names, but generally you're right, and I don't object to being precise :) (counter-nit: Leave out the "-" in "pref name") jkrcal 2016/07/21 18:17:57 Done. Show quoted text On 2016/07/21 11:43:50, Marc Treib wrote: > On 2016/07/21 11:37:09, tschumann wrote: > > sorry for being nit-picky: But this constant is a name not a count :-) Would > you > > mind updating the comment like: > > // The pref-name for the NTPSnippetsFetcher requests for today counter. > > > > [i'm unsure if i'm using proper terminology though] > > I think it's fairly common to have this type of comment on pref names, but > generally you're right, and I don't object to being precise :) > (counter-nit: Leave out the "-" in "pref name") Done.
	18 extern const char kSnippetFetcherQuotaCount[];

	19

15 } // namespace prefs	20 } // namespace prefs

16 } // namespace ntp_snippets	21 } // namespace ntp_snippets

17	22

18 #endif	23 #endif // COMPONENTS_NTP_SNIPPETS_PREF_NAMES_H_

OLD	NEW

« no previous file with comments | « components/ntp_snippets/BUILD.gn ('k') | components/ntp_snippets/pref_names.cc » ('j') | components/ntp_snippets/request_counter.h » ('J')