Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 2158833002: Factor DocumentSubresourceFilter out of SubresourceFilterAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from pkalinnikov@ Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/chrome_content_renderer_client.h" 5 #include "chrome/renderer/chrome_content_renderer_client.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 494 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 // Set up a mojo service to test if this page is a contextual search page. 505 // Set up a mojo service to test if this page is a contextual search page.
506 new contextual_search::OverlayJsRenderFrameObserver(render_frame); 506 new contextual_search::OverlayJsRenderFrameObserver(render_frame);
507 507
508 PasswordAutofillAgent* password_autofill_agent = 508 PasswordAutofillAgent* password_autofill_agent =
509 new PasswordAutofillAgent(render_frame); 509 new PasswordAutofillAgent(render_frame);
510 PasswordGenerationAgent* password_generation_agent = 510 PasswordGenerationAgent* password_generation_agent =
511 new PasswordGenerationAgent(render_frame, password_autofill_agent); 511 new PasswordGenerationAgent(render_frame, password_autofill_agent);
512 new AutofillAgent(render_frame, password_autofill_agent, 512 new AutofillAgent(render_frame, password_autofill_agent,
513 password_generation_agent); 513 password_generation_agent);
514 514
515 new subresource_filter::SubresourceFilterAgent( 515 // There is no render thread, thus no RulesetDealer in ChromeRenderViewTests.
516 render_frame, subresource_filter_ruleset_dealer_.get()); 516 if (subresource_filter_ruleset_dealer_) {
517 new subresource_filter::SubresourceFilterAgent(
518 render_frame, subresource_filter_ruleset_dealer_.get());
519 }
517 } 520 }
518 521
519 void ChromeContentRendererClient::RenderViewCreated( 522 void ChromeContentRendererClient::RenderViewCreated(
520 content::RenderView* render_view) { 523 content::RenderView* render_view) {
521 #if defined(ENABLE_EXTENSIONS) 524 #if defined(ENABLE_EXTENSIONS)
522 ChromeExtensionsRendererClient::GetInstance()->RenderViewCreated(render_view); 525 ChromeExtensionsRendererClient::GetInstance()->RenderViewCreated(render_view);
523 #endif 526 #endif
524 new PageLoadHistograms(render_view); 527 new PageLoadHistograms(render_view);
525 #if defined(ENABLE_PRINTING) 528 #if defined(ENABLE_PRINTING)
526 new printing::PrintWebViewHelper( 529 new printing::PrintWebViewHelper(
(...skipping 851 matching lines...) Expand 10 before | Expand all | Expand 10 after
1378 // chrome.system.network.getNetworkInterfaces provides the same 1381 // chrome.system.network.getNetworkInterfaces provides the same
1379 // information. Also, the enforcement of sending and binding UDP is already done 1382 // information. Also, the enforcement of sending and binding UDP is already done
1380 // by chrome extension permission model. 1383 // by chrome extension permission model.
1381 bool ChromeContentRendererClient::ShouldEnforceWebRTCRoutingPreferences() { 1384 bool ChromeContentRendererClient::ShouldEnforceWebRTCRoutingPreferences() {
1382 #if defined(ENABLE_EXTENSIONS) 1385 #if defined(ENABLE_EXTENSIONS)
1383 return !IsStandaloneExtensionProcess(); 1386 return !IsStandaloneExtensionProcess();
1384 #else 1387 #else
1385 return true; 1388 return true;
1386 #endif 1389 #endif
1387 } 1390 }
OLDNEW
« no previous file with comments | « no previous file | components/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698