Factor DocumentSubresourceFilter out of SubresourceFilterAgent.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 494 matching lines @@
   // Set up a mojo service to test if this page is a contextual search page.
   new contextual_search::OverlayJsRenderFrameObserver(render_frame);
 
   PasswordAutofillAgent* password_autofill_agent =
       new PasswordAutofillAgent(render_frame);
   PasswordGenerationAgent* password_generation_agent =
       new PasswordGenerationAgent(render_frame, password_autofill_agent);
   new AutofillAgent(render_frame, password_autofill_agent,
                     password_generation_agent);
 
-  new subresource_filter::SubresourceFilterAgent(
-      render_frame, subresource_filter_ruleset_dealer_.get());
+  // There is no render thread, thus no RulesetDealer in ChromeRenderViewTests.
+  if (subresource_filter_ruleset_dealer_) {
+    new subresource_filter::SubresourceFilterAgent(

[pkalinnikov, 2016/07/19 11:57:32]

How does this object not leak?

[engedy, 2016/07/19 12:57:28]

As a RenderFrameObserver it is owned by the |render_frame|, which takes care of
destruction.

[pkalinnikov, 2016/07/19 13:45:18]

Acknowledged.

+        render_frame, subresource_filter_ruleset_dealer_.get());
+  }
 }
 
 void ChromeContentRendererClient::RenderViewCreated(
     content::RenderView* render_view) {
 #if defined(ENABLE_EXTENSIONS)
   ChromeExtensionsRendererClient::GetInstance()->RenderViewCreated(render_view);
 #endif
   new PageLoadHistograms(render_view);
 #if defined(ENABLE_PRINTING)
   new printing::PrintWebViewHelper(
@@ skipping 851 matching lines @@
 // chrome.system.network.getNetworkInterfaces provides the same
 // information. Also, the enforcement of sending and binding UDP is already done
 // by chrome extension permission model.
 bool ChromeContentRendererClient::ShouldEnforceWebRTCRoutingPreferences() {
 #if defined(ENABLE_EXTENSIONS)
   return !IsStandaloneExtensionProcess();
 #else
   return true;
 #endif
 }