Web Animations: Introduce String based KeyframeEffectModel

Source/core/animation/Interpolation.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef Interpolation_h
 #define Interpolation_h
 
 #include "CSSPropertyNames.h"
 #include "core/animation/InterpolableValue.h"
 #include "heap/Handle.h"
@@ skipping 27 matching lines @@
     mutable int m_cachedIteration;
     mutable OwnPtr<InterpolableValue> m_cachedValue;
 
     Interpolation(PassOwnPtr<InterpolableValue> start, PassOwnPtr<InterpolableValue> end);
 
 private:
     InterpolableValue* getCachedValueForTesting() const { return m_cachedValue.get(); }
 
     friend class AnimationInterpolableValueTest;
     friend class AnimationInterpolationEffectTest;
-
 };
 
 class StyleInterpolation : public Interpolation {
 public:
     // 1) convert m_cachedValue into an X
     // 2) shove X into StyleResolverState
     // X can be:
     // (1) a CSSValue (and applied via StyleBuilder::applyProperty)
     // (2) an AnimatableValue (and applied via // AnimatedStyleBuilder::applyProperty)
     // (3) a custom value that is inserted directly into the StyleResolverState.
     virtual void apply(StyleResolverState&) const = 0;
 
     virtual bool isStyleInterpolation() const OVERRIDE FINAL { return true; }
+    // FIXME: This method exists for two reasons:
+    // * tests use it to extract values without applying them
+    // * interrupted compositor transitions use it to generate a new set of
+    //   keyframes representing the retargeted transition.
+    // Once KeyframeEffectModel objects can be generated from
+    // InterpolationEffect objects, we can use this approach in both cases,
+    // and remove this method.
+    virtual PassRefPtr<AnimatableValue> currentValue() const
+    {
+        ASSERT_NOT_REACHED();
+        return nullptr;
+    }

[alancutter (OOO until 2018), 2014/04/01 03:12:48]

Adding currentValue() to StyleInterpolation is likely a remnant of
OpacityStyleInterpolation that I was supposed to remove in my patch.
My mistake, there probably shouldn't be any changes to Interpolation in this
patch.

[shans, 2014/04/01 04:01:27]

Done.

 
     CSSPropertyID id() const { return m_id; }
 
     virtual void trace(Visitor*) OVERRIDE;
 
 protected:
     CSSPropertyID m_id;
 
     StyleInterpolation(PassOwnPtr<InterpolableValue> start, PassOwnPtr<InterpolableValue> end, CSSPropertyID id)
         : Interpolation(start, end)
         , m_id(id)
     {
     }
 };
 
 class LegacyStyleInterpolation : public StyleInterpolation {
 public:
     static PassRefPtrWillBeRawPtr<LegacyStyleInterpolation> create(PassRefPtrWillBeRawPtr<AnimatableValue> start, PassRefPtrWillBeRawPtr<AnimatableValue> end, CSSPropertyID id)
     {
         return adoptRefWillBeNoop(new LegacyStyleInterpolation(InterpolableAnimatableValue::create(start), InterpolableAnimatableValue::create(end), id));
     }
 
     virtual void apply(StyleResolverState&) const;
 
     virtual bool isLegacyStyleInterpolation() const OVERRIDE FINAL { return true; }
-    AnimatableValue* currentValue() const
+    PassRefPtr<AnimatableValue> currentValue() const
     {
         InterpolableAnimatableValue* value = static_cast<InterpolableAnimatableValue*>(m_cachedValue.get());
         return value->value();
     }
 
     virtual void trace(Visitor*) OVERRIDE;
 
 private:
     LegacyStyleInterpolation(PassOwnPtr<InterpolableValue> start, PassOwnPtr<InterpolableValue> end, CSSPropertyID id)
         : StyleInterpolation(start, end, id)
     {
     }
 };
 
 DEFINE_TYPE_CASTS(StyleInterpolation, Interpolation, value, value->isStyleInterpolation(), value.isStyleInterpolation());
 DEFINE_TYPE_CASTS(LegacyStyleInterpolation, Interpolation, value, value->isLegacyStyleInterpolation(), value.isLegacyStyleInterpolation());
 
 }
 #endif