DescriptionRevert of Mojo: add javascript bindings for request/response (https://codereview.chromium.org/207503004/)
Reason for revert:
broke WebUIMojoTest.EndToEnd test.
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35528/steps/content_browsertests/logs/EndToEnd
Original issue's description:
> Mojo: add javascript bindings for request/response
>
> If a mojom interface method specifies response parameters, then we'll generate javascript bindings that provide an additional callback parameter used to pass the response parameters. This mirrors the C++ implementation.
>
> A future improvement will likely be to use promises instead, especially now that they are enabled on trunk.
>
> As part of this CL, connector.js was also made consistent with connector.cc. It starts reading the message pipe immediately, handles write failures in a similar fashion, etc.
>
> The Connection type from connector.js is factored out into a separate file as it now holds a Router object. router.js mirrors router.cc. The Connection type is really the mirror of the C++ RemotePtr<S> type.
>
> Some basic request/response tests were added to connection_unittests.js. We'll probably want more testing.
>
> R=abarth@chromium.org, mpcomplete@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259932
TBR=mpcomplete@chromium.org,abarth@chromium.org,darin@chromium.org
NOTREECHECKS=true
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260043
Patch Set 1 #
Created: 6 years, 9 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|