Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 215883004: Revert of Mojo: add javascript bindings for request/response (Closed)

Created:
6 years, 9 months ago by tkent
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, viettrungluu+watch_chromium.org, ben+mojo_chromium.org
Visibility:
Public.

Description

Revert of Mojo: add javascript bindings for request/response (https://codereview.chromium.org/207503004/) Reason for revert: broke WebUIMojoTest.EndToEnd test. http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35528/steps/content_browsertests/logs/EndToEnd Original issue's description: > Mojo: add javascript bindings for request/response > > If a mojom interface method specifies response parameters, then we'll generate javascript bindings that provide an additional callback parameter used to pass the response parameters. This mirrors the C++ implementation. > > A future improvement will likely be to use promises instead, especially now that they are enabled on trunk. > > As part of this CL, connector.js was also made consistent with connector.cc. It starts reading the message pipe immediately, handles write failures in a similar fashion, etc. > > The Connection type from connector.js is factored out into a separate file as it now holds a Router object. router.js mirrors router.cc. The Connection type is really the mirror of the C++ RemotePtr<S> type. > > Some basic request/response tests were added to connection_unittests.js. We'll probably want more testing. > > R=abarth@chromium.org, mpcomplete@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259932 TBR=mpcomplete@chromium.org,abarth@chromium.org,darin@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -496 lines) Patch
D mojo/apps/js/bindings/connection_unittests.js View 1 chunk +0 lines, -237 lines 0 comments Download
A mojo/apps/js/bindings/connector_unittests.js View 1 chunk +132 lines, -0 lines 0 comments Download
M mojo/apps/js/main.js View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/apps/js/test/run_apps_js_tests.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/bindings/generators/js_templates/interface_definition.tmpl View 3 chunks +1 line, -62 lines 0 comments Download
M mojo/public/bindings/js/codec.js View 5 chunks +4 lines, -45 lines 0 comments Download
D mojo/public/bindings/js/connection.js View 1 chunk +0 lines, -30 lines 0 comments Download
M mojo/public/bindings/js/connector.js View 3 chunks +30 lines, -36 lines 0 comments Download
D mojo/public/bindings/js/router.js View 1 chunk +0 lines, -75 lines 0 comments Download
M mojo/public/bindings/pylib/generate/mojom_generator.py View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/bindings/tests/sample_interfaces.mojom View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
Created Revert of Mojo: add javascript bindings for request/response
6 years, 9 months ago (2014-03-28 00:42:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/215883004/1
6 years, 9 months ago (2014-03-28 00:43:22 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 00:46:35 UTC) #3
Message was sent while issue was closed.
Change committed as 260043

Powered by Google App Engine
This is Rietveld 408576698