program_manager::CheckPacking, sends full sh::ShaderVariable

program_manager::CheckPacking, sends full sh::ShaderVariable

CheckVaryingPacking used to send stripped-down varying information to
ShCheckVariablesWithinPackingLimits but this was incorrect for GLSL ES
3 that supports structure as varyings. Make use of a new
ShCheckVariablesWithinPackingLimits entry point that takes the full
sh::ShaderVariable information.

This fixes an assert in the deqp/data/gles3/shaders/linkage.html WebGL
2 tests.

BUG=621031
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d138862def50d5228bf2403bc301b41b4312a5de
Cr-Commit-Position: refs/heads/master@{#406421}

[Corentin Wallez, 2016-07-18 20:34:02]

Description was changed from

==========
program_manager::CheckPacking, sends full sh::ShaderVariable

CheckVaryingPacking used to send stripped-down varying information to
ShCheckVariablesWithinPackingLimits but this was incorrect for GLSL ES
3 that supports structure as varyings. Make use of a new
ShCheckVariablesWithinPackingLimits entry point that takes the full
sh::ShaderVariable information.

This fixes an assert in the deqp/data/gles3/shaders/linkage.html WebGL
2 tests.

BUG=621031
==========

to

==========
program_manager::CheckPacking, sends full sh::ShaderVariable

CheckVaryingPacking used to send stripped-down varying information to
ShCheckVariablesWithinPackingLimits but this was incorrect for GLSL ES
3 that supports structure as varyings. Make use of a new
ShCheckVariablesWithinPackingLimits entry point that takes the full
sh::ShaderVariable information.

This fixes an assert in the deqp/data/gles3/shaders/linkage.html WebGL
2 tests.

BUG=621031
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-07-18 20:52:47]

cwallez@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[Corentin Wallez, 2016-07-18 20:52:47]

PTAL, this will land after https://chromium-review.googlesource.com/c/361460/ is
landed and rolled.

[Ken Russell (switch to Gerrit), 2016-07-18 21:40:40]

LGTM though I'm not an OWNER. Good work tracking this down.

[Zhenyao Mo, 2016-07-18 21:53:23]

lgtm

[Corentin Wallez, 2016-07-19 19:48:45]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-07-19 19:49:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 22:10:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 22:10:45]

Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Corentin Wallez, 2016-07-19 22:47:42]

On 2016/07/19 at 22:10:45, commit-bot wrote:
> Try jobs failed on following builders:
>   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

Trying again, investigating the failure in parallel

[Corentin Wallez, 2016-07-19 22:47:48]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-07-19 22:48:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 00:04:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-20 00:04:07]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 00:05:42]

Description was changed from

==========
program_manager::CheckPacking, sends full sh::ShaderVariable

CheckVaryingPacking used to send stripped-down varying information to
ShCheckVariablesWithinPackingLimits but this was incorrect for GLSL ES
3 that supports structure as varyings. Make use of a new
ShCheckVariablesWithinPackingLimits entry point that takes the full
sh::ShaderVariable information.

This fixes an assert in the deqp/data/gles3/shaders/linkage.html WebGL
2 tests.

BUG=621031
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
program_manager::CheckPacking, sends full sh::ShaderVariable

CheckVaryingPacking used to send stripped-down varying information to
ShCheckVariablesWithinPackingLimits but this was incorrect for GLSL ES
3 that supports structure as varyings. Make use of a new
ShCheckVariablesWithinPackingLimits entry point that takes the full
sh::ShaderVariable information.

This fixes an assert in the deqp/data/gles3/shaders/linkage.html WebGL
2 tests.

BUG=621031
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d138862def50d5228bf2403bc301b41b4312a5de
Cr-Commit-Position: refs/heads/master@{#406421}
==========

[commit-bot: I haz the power, 2016-07-20 00:05:43]

Patchset 1 (id:??) landed as
https://crrev.com/d138862def50d5228bf2403bc301b41b4312a5de
Cr-Commit-Position: refs/heads/master@{#406421}

[Ken Russell (switch to Gerrit), 2016-07-20 19:46:03]

On 2016/07/19 22:47:42, Corentin Wallez wrote:
> On 2016/07/19 at 22:10:45, commit-bot wrote:
> > Try jobs failed on following builders:
> >   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
> 
> Trying again, investigating the failure in parallel

This was an instance of http://crbug.com/609252 . The GPU process hung while
running the test.