Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: components/content_settings/core/browser/host_content_settings_map.h

Issue 2158743002: Register a pref to control migration status (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@change_scoping_type
Patch Set: address review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/host_content_settings_map.h
diff --git a/components/content_settings/core/browser/host_content_settings_map.h b/components/content_settings/core/browser/host_content_settings_map.h
index 9115c2836a932b70c52fada8c8d6c27a991f454e..c9f666a6267bfe0899b517272122d4d32439b9e2 100644
--- a/components/content_settings/core/browser/host_content_settings_map.h
+++ b/components/content_settings/core/browser/host_content_settings_map.h
@@ -280,8 +280,12 @@ class HostContentSettingsMap : public content_settings::Observer,
private:
friend class base::RefCountedThreadSafe<HostContentSettingsMap>;
- friend class HostContentSettingsMapTest_MigrateDomainScopedSettings_Test;
- friend class HostContentSettingsMapTest_MigrateKeygenSettings_Test;
+
+ FRIEND_TEST_ALL_PREFIXES(HostContentSettingsMapTest,
+ DomainToOriginMigrationStatus);
+ FRIEND_TEST_ALL_PREFIXES(HostContentSettingsMapTest,
+ MigrateDomainScopedSettings);
+ FRIEND_TEST_ALL_PREFIXES(HostContentSettingsMapTest, MigrateKeygenSettings);
friend class content_settings::TestUtils;
@@ -316,9 +320,12 @@ class HostContentSettingsMap : public content_settings::Observer,
// ContentSettingsTypes which are domain scoped. Only narrow down ALLOW
// domain settings to origins so that this will not cause privacy/security
// issues.
+ //
+ // |after_sync| will be false when called upon construction of this object and
+ // true when called by the sync layer after sync is completed.
// TODO(lshang): https://crbug.com/621398 Remove this when clients have
// migrated (~M56).
- void MigrateDomainScopedSettings();
+ void MigrateDomainScopedSettings(bool after_sync);
// Collect UMA data about the number of exceptions.
void RecordNumberOfExceptions();

Powered by Google App Engine
This is Rietveld 408576698