Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2158703002: Fix frameset accessibility (Closed)

Created:
4 years, 5 months ago by dmazzoni
Modified:
4 years, 5 months ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, mlamouri+watch-content_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix frameset accessibility BUG=414157 Committed: https://crrev.com/869f8683fa70c3120e99add72a0c09f734aac358 Cr-Commit-Position: refs/heads/master@{#406111}

Patch Set 1 #

Patch Set 2 : Fix win expectations #

Patch Set 3 : Fix win expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -23 lines) Patch
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +6 lines, -8 lines 0 comments Download
A content/test/data/accessibility/html/frameset-expected-blink.txt View 1 chunk +22 lines, -0 lines 0 comments Download
M content/test/data/accessibility/html/frameset-expected-mac.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/frameset-expected-win.txt View 1 2 1 chunk +11 lines, -13 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
dmazzoni
4 years, 5 months ago (2016-07-18 04:57:58 UTC) #8
nektarios
lgtm
4 years, 5 months ago (2016-07-18 16:16:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158703002/40001
4 years, 5 months ago (2016-07-18 18:55:39 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/105745)
4 years, 5 months ago (2016-07-18 20:39:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158703002/40001
4 years, 5 months ago (2016-07-18 20:43:27 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-18 21:57:07 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:59:19 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/869f8683fa70c3120e99add72a0c09f734aac358
Cr-Commit-Position: refs/heads/master@{#406111}

Powered by Google App Engine
This is Rietveld 408576698