Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2158673002: Fuchsia: Hello, Fuchsia! (Closed)

Created:
4 years, 5 months ago by zra
Modified:
4 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Long line #

Patch Set 3 : Merge, cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -16 lines) Patch
M runtime/bin/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/fuchsia_test.cc View 1 2 2 chunks +166 lines, -10 lines 0 comments Download
M runtime/platform/utils_fuchsia.h View 1 chunk +14 lines, -4 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 5 months ago (2016-07-18 15:56:18 UTC) #2
siva
lgtm
4 years, 5 months ago (2016-07-18 16:23:52 UTC) #3
zra
4 years, 5 months ago (2016-07-18 17:35:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b30da81483e327d382cefbca849e0c7ba1e64627 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698