Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2158653002: Linux UI: Add IsVisibleOnAllWorkspaces() (Closed)

Created:
4 years, 5 months ago by Tom (Use chromium acct)
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux UI: Add IsVisibleOnAllWorkspaces() CL404544 gave precedence to the browsers on the current workspace when opening a tab in an existing browser session, however it did not take into account that windows may be on all workspaces. BUG=619673 Committed: https://crrev.com/dbf499f5aa00782185d392848204284bde71b448 Cr-Commit-Position: refs/heads/master@{#406200}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Add mac impl #

Patch Set 4 : Add more mac impls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -2 lines) Patch
M chrome/browser/ui/browser_list.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/test_browser_window.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_mac.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_mac.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_private.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/widget.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
Tom (Use chromium acct)
sky@ PTAL Not sure if we need the complexity introduced by IsVisibleOnAllWorkspaces or if "const ...
4 years, 5 months ago (2016-07-18 17:58:29 UTC) #6
sky
LGTM
4 years, 5 months ago (2016-07-18 19:59:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158653002/60001
4 years, 5 months ago (2016-07-19 03:11:30 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-19 03:19:04 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 03:19:08 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 03:21:37 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dbf499f5aa00782185d392848204284bde71b448
Cr-Commit-Position: refs/heads/master@{#406200}

Powered by Google App Engine
This is Rietveld 408576698