Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2158633002: cc: DCHECK background_image_id only if there is a background image (Closed)

Created:
4 years, 5 months ago by jaydasika
Modified:
4 years, 5 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: DCHECK background_image_id only if there is a background image CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/92f219ff71fbe100c71f96e79d2c4cf99a43a7fd Cr-Commit-Position: refs/heads/master@{#405923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M cc/output/gl_renderer.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
jaydasika
I was hitting this DCHECK while working on some other bug. ApplyBackgroundFilters can return nullptr, ...
4 years, 5 months ago (2016-07-15 23:49:00 UTC) #4
enne (OOO)
lgtm
4 years, 5 months ago (2016-07-16 01:05:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158633002/1
4 years, 5 months ago (2016-07-16 02:24:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-16 02:27:43 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-16 02:27:47 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 02:29:47 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92f219ff71fbe100c71f96e79d2c4cf99a43a7fd
Cr-Commit-Position: refs/heads/master@{#405923}

Powered by Google App Engine
This is Rietveld 408576698