Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 215863002: MSE: Update tests to expect failure w.r.t. Chromium LegacyFrameProcessor duration logic change (Closed)

Created:
6 years, 9 months ago by wolenetz
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

MSE: Update tests to expect failure w.r.t. Chromium LegacyFrameProcessor duration logic change Chromium-side change to LegacyFrameProcessor to use frame duration, if available, during AppendWindow filtering and IncreaseDurationCB will cause layout tests to fail until they are updated. This change adds those failure expectations plus WebM (and relevant unprefixed MSE MP4) expectation updates that work locally after the Chromium-side change (http://codereview.chromium.org/205703003) is applied (and for MP4 layout testing, with webm codec support locally disabled in Chromium stream parser factory). R=acolwell@chromium.org BUG=249422 TEST=All media layout tests pass locally on Linux before and after the Chromium-side change is applied (including relevant MSE MP4 tests) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170398

Patch Set 1 #

Patch Set 2 : Update unprefixed MP4 layout test duration #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +10 lines, -3 lines 2 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-buffered.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-remove.html View 4 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-seek-beyond-duration.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-util.js View 1 2 chunks +9 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/media/resources/media-source/webm/segment-info.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
acolwell GONE FROM CHROMIUM
please update the MP4 expectations too. The easiest way to do this is to s/webm/webm2 ...
6 years, 9 months ago (2014-03-28 00:44:18 UTC) #1
wolenetz
You read my mind :) PTAL @ PS2. Thanks!
6 years, 9 months ago (2014-03-28 02:00:32 UTC) #2
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/215863002/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/215863002/diff/20001/LayoutTests/TestExpectations#newcode524 LayoutTests/TestExpectations:524: crbug.com/249422 http/tests/media/media-source/webkitmediasource-duration-changed.html [ Failure Pass ] Why was this ...
6 years, 9 months ago (2014-03-28 23:00:54 UTC) #3
wolenetz
https://codereview.chromium.org/215863002/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/215863002/diff/20001/LayoutTests/TestExpectations#newcode524 LayoutTests/TestExpectations:524: crbug.com/249422 http/tests/media/media-source/webkitmediasource-duration-changed.html [ Failure Pass ] On 2014/03/28 23:00:54, ...
6 years, 9 months ago (2014-03-28 23:25:45 UTC) #4
acolwell GONE FROM CHROMIUM
lgtm
6 years, 9 months ago (2014-03-29 00:34:11 UTC) #5
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 9 months ago (2014-03-29 00:59:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/215863002/20001
6 years, 9 months ago (2014-03-29 00:59:11 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 01:26:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-29 01:26:55 UTC) #9
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 9 months ago (2014-03-29 01:36:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/215863002/20001
6 years, 9 months ago (2014-03-29 01:36:34 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-29 02:08:57 UTC) #12
Message was sent while issue was closed.
Change committed as 170398

Powered by Google App Engine
This is Rietveld 408576698