Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: components/metrics/proto/memory_leak_report.proto

Issue 2158583002: Add build ID field to MemoryLeakReportProto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/proto/memory_leak_report.proto
diff --git a/components/metrics/proto/memory_leak_report.proto b/components/metrics/proto/memory_leak_report.proto
index bbd2dbc7a6615b1e56585d67f08cb3cd8e1b2f19..2a25f3857a1e31cd7e91df6de9ef8da31092821b 100644
--- a/components/metrics/proto/memory_leak_report.proto
+++ b/components/metrics/proto/memory_leak_report.proto
@@ -8,7 +8,7 @@ option optimize_for = LITE_RUNTIME;
package metrics;
-// Next tag: 6
+// Next tag: 7
message MemoryLeakReportProto {
// The call stack at which the leak was found. This is a list of offsets
// within the program binary. The first entry is the deepest level of the call
@@ -69,6 +69,12 @@ message MemoryLeakReportProto {
}
optional ProcessType source_process = 5;
+ // The build ID of the Chrome binary from which this leak report was obtained.
+ // The build ID is typically a 16- or 20-byte hash that is generated by the
+ // compiler that built the binary. This value will be read directly from the
+ // GNU build notes section of the Chrome binary.
+ optional bytes build_id = 6;
+
//////////////////////////////////////////////////////////////////////////////
// Represents a single snapshot of the internal bookkeeping of the Runtime
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698