Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2158583002: Add build ID field to MemoryLeakReportProto (Closed)

Created:
4 years, 5 months ago by Simon Que
Modified:
4 years, 5 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, Will Harris
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add build ID field to MemoryLeakReportProto BUG=chromium:627873 TEST=build successfully Committed: https://crrev.com/84bb999bd0ed887c26f04f58715fda5b03271f90 Cr-Commit-Position: refs/heads/master@{#405883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M components/metrics/proto/memory_leak_report.proto View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Simon Que
4 years, 5 months ago (2016-07-15 21:41:42 UTC) #2
Ilya Sherman
lgtm
4 years, 5 months ago (2016-07-15 21:56:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158583002/1
4 years, 5 months ago (2016-07-15 21:56:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 22:37:53 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 22:39:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84bb999bd0ed887c26f04f58715fda5b03271f90
Cr-Commit-Position: refs/heads/master@{#405883}

Powered by Google App Engine
This is Rietveld 408576698