Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2158563002: Put a NoOOBMessageScope everywhere we have a NoReloadScope (Closed)

Created:
4 years, 5 months ago by Cutch
Modified:
4 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Put a NoOOBMessageScope everywhere we have a NoReloadScope. This is an attempt at fixing the developer_extension_test flake. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/56d031874ff6e7f699351e98f511095e74712358

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/vm/parser.cc View 4 chunks +4 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 5 months ago (2016-07-15 20:33:44 UTC) #3
rmacnak
LGTM https://codereview.chromium.org/2158563002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/2158563002/diff/1/runtime/vm/parser.cc#newcode12281 runtime/vm/parser.cc:12281: RawObject* Parser::EvaluateConstConstructorCall( Coulda swore we already had this ...
4 years, 5 months ago (2016-07-15 20:39:08 UTC) #4
Cutch
4 years, 5 months ago (2016-07-15 20:41:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
56d031874ff6e7f699351e98f511095e74712358 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698