Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 2158503002: Remove the declaration of localFrameRootTemporary. (Closed)

Created:
3 years, 9 months ago by Avi (use Gerrit)
Modified:
3 years, 9 months ago
Reviewers:
kenrb, esprehn, dcheng
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the declaration of localFrameRootTemporary. The definition was removed in r189999. BUG=419087 Committed: https://crrev.com/dfa559ef79c6c8027d24c6f81305aecd650bb20a Cr-Commit-Position: refs/heads/master@{#405840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Avi (use Gerrit)
3 years, 9 months ago (2016-07-15 18:40:53 UTC) #4
kenrb
lgtm, presumably that was an oversight.
3 years, 9 months ago (2016-07-15 19:23:37 UTC) #5
esprehn
lgtm
3 years, 9 months ago (2016-07-15 20:07:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158503002/1
3 years, 9 months ago (2016-07-15 20:08:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 9 months ago (2016-07-15 20:13:08 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2016-07-15 20:15:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfa559ef79c6c8027d24c6f81305aecd650bb20a
Cr-Commit-Position: refs/heads/master@{#405840}

Powered by Google App Engine
This is Rietveld 408576698