Utility class of static methods to efficiently manipulate typed JSInterop objects in a dynamic mann…

Utility class of static methods to efficiently manipulate typed JSInterop objects in a dynamic manner. Fix for @JS classes that are _private. Bug #25038 @JS on a _Private class in Dartium

Tests are in the separate Dart2JS CL

BUG=
R=alanknight@google.com

Committed: https://github.com/dart-lang/sdk/commit/e010460709cb952c59715ea2c2c3473408fa4838

[Jacob, 2016-07-16 00:20:31]

jacobr@google.com changed reviewers:
+ alanknight@google.com

[Jacob, 2016-07-16 00:20:31]

Fixes the following issues
#25038 @JS on a _Private class in Dartium (simple fix)

#26718 Make JS$ work properly in Dartium.

[Alan Knight, 2016-07-19 16:56:16]

lgtm

https://codereview.chromium.org/2158493003/diff/1/sdk/lib/js/dartium/js_darti...
File sdk/lib/js/dartium/js_dartium.dart (right):

https://codereview.chromium.org/2158493003/diff/1/sdk/lib/js/dartium/js_darti...
sdk/lib/js/dartium/js_dartium.dart:113: final String escapePrivateClassPrefix =
r'$JSImplClass23402893498';
Is this a problem if there are two different private classes, in separate
libraries, but both visible, that have the same name?

[Jacob, 2016-07-19 17:36:40]

https://codereview.chromium.org/2158493003/diff/1/sdk/lib/js/dartium/js_darti...
File sdk/lib/js/dartium/js_dartium.dart (right):

https://codereview.chromium.org/2158493003/diff/1/sdk/lib/js/dartium/js_darti...
sdk/lib/js/dartium/js_dartium.dart:113: final String escapePrivateClassPrefix =
r'$JSImplClass23402893498';
On 2016/07/19 16:56:16, Alan Knight wrote:
> Is this a problem if there are two different private classes, in separate
> libraries, but both visible, that have the same name?
No because all libraries are imported into the dart:js patch file using
prefixes.

[Jacob, 2016-07-19 17:37:24]

Description was changed from

==========
Utility class of static methods to efficiently manipulate typed JSInterop
objects in a dynamic manner. Fix for @JS classes that are _private. Bug #25038
@JS on a _Private class in Dartium

Tests are in the separate Dart2JS CL

BUG=
==========

to

==========
Utility class of static methods to efficiently manipulate typed JSInterop
objects in a dynamic manner. Fix for @JS classes that are _private. Bug #25038
@JS on a _Private class in Dartium

Tests are in the separate Dart2JS CL

BUG=
R=alanknight@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e010460709cb952c59715ea2c2c3473408fa4838
==========

[Jacob, 2016-07-19 17:37:25]

Committed patchset #1 (id:1) manually as
e010460709cb952c59715ea2c2c3473408fa4838 (presubmit successful).