Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2158473002: Consolidate Windows bitmap and DC code (Closed)

Created:
4 years, 5 months ago by tomhudson
Modified:
4 years, 5 months ago
Reviewers:
f(malita)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consolidate Windows bitmap and DC code Move code out of skia::BitmapPlatformDevice so we can access it from other parts of Chrome; extracted from a more complex CL. R=fmalita@chromium.org BUG=543755 Committed: https://crrev.com/3a64a4b079f4cbd356a76ca9dd2cc339385ad2f3 Cr-Commit-Position: refs/heads/master@{#405853}

Patch Set 1 #

Patch Set 2 : cut-and-paste error #

Total comments: 1

Patch Set 3 : review error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -37 lines) Patch
M skia/ext/bitmap_platform_device_win.cc View 2 chunks +2 lines, -36 lines 0 comments Download
M skia/ext/skia_utils_win.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M skia/ext/skia_utils_win.cc View 2 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
tomhudson
PTAL, I think the test failures are swarming? I want to do this with a ...
4 years, 5 months ago (2016-07-15 18:35:26 UTC) #1
f(malita)
lgtm https://codereview.chromium.org/2158473002/diff/20001/skia/ext/skia_utils_win.h File skia/ext/skia_utils_win.h (right): https://codereview.chromium.org/2158473002/diff/20001/skia/ext/skia_utils_win.h#newcode64 skia/ext/skia_utils_win.h:64: SK_API void CreateBitmapHeader(int width, int height, BITMAPINFOHEADER* hdr); ...
4 years, 5 months ago (2016-07-15 19:04:03 UTC) #2
tomhudson
On 2016/07/15 19:04:03, f(malita) wrote: > lgtm > > https://codereview.chromium.org/2158473002/diff/20001/skia/ext/skia_utils_win.h > File skia/ext/skia_utils_win.h (right): > ...
4 years, 5 months ago (2016-07-15 19:05:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158473002/40001
4 years, 5 months ago (2016-07-15 19:07:33 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-15 20:53:35 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 20:56:55 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3a64a4b079f4cbd356a76ca9dd2cc339385ad2f3
Cr-Commit-Position: refs/heads/master@{#405853}

Powered by Google App Engine
This is Rietveld 408576698