chrome/browser/ui/cocoa/notifications/notification_delivery.h - Issue 2158463003: Initial client side implementation of the XPC service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/notifications/notification_delivery.h

Issue 2158463003: Initial client side implementation of the XPC service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/notifications/notification_platform_bridge_mac.mm ('K') | « chrome/browser/ui/cocoa/notifications/notification_constants_mac.mm ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_COCOA_NOTIFICATIONS_NOTIFICATION_DELIVERY_H_

	6 #define CHROME_BROWSER_UI_COCOA_NOTIFICATIONS_NOTIFICATION_DELIVERY_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 // Collection of protocols used for XPC communication between chrome

	11 // and the alert notification xpc service.

	12

	13 // Indicate the XPC service that it needs to display an alert.
	Robert Sesek 2016/09/08 21:10:08 "Protocol for the XPC notification service." "Protocol for the XPC notification service." Miguel Garcia 2016/09/12 13:49:00 Done. Show quoted text On 2016/09/08 21:10:08, Robert Sesek wrote: > "Protocol for the XPC notification service." Done.
	14 // \|notificationData\| is generated using a NofiticationBuilder object.
	Robert Sesek 2016/09/08 21:10:09 This should be next to -deliverNotification:. This should be next to -deliverNotification:. Miguel Garcia 2016/09/12 13:49:01 Done. Show quoted text On 2016/09/08 21:10:09, Robert Sesek wrote: > This should be next to -deliverNotification:. Done.
	15 @protocol NotificationDelivery

	16

	17 - (void)deliverNotification:(NSDictionary*)notificationData;

	18

	19 @end

	20

	21 // Used to talk back from the XPC service to chrome upon a notification click.
	Robert Sesek 2016/09/08 21:10:09 "Response protocol for the XPC notification servic "Response protocol for the XPC notification service to notify Chrome of notification interactions." Miguel Garcia 2016/09/12 13:49:01 Done. Show quoted text On 2016/09/08 21:10:09, Robert Sesek wrote: > "Response protocol for the XPC notification service to notify Chrome of > notification interactions." Done.
	22 // \|notificationResponseData\| is generated through a
	Robert Sesek 2016/09/08 21:10:08 Move down next to the method. Move down next to the method. Miguel Garcia 2016/09/12 13:49:01 Done. Show quoted text On 2016/09/08 21:10:08, Robert Sesek wrote: > Move down next to the method. Done.
	23 // NotificationResponseBuilder.

	24 @protocol NotificationReply

	25

	26 - (void)notificationClick:(NSDictionary*)notificationResponseData;

	27

	28 @end

	29

	30 #endif // CHROME_BROWSER_UI_COCOA_NOTIFICATIONS_NOTIFICATION_DELIVERY_H_

OLD	NEW