Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2158443002: [turbofan] Fix deopt point for [[ToObject]] lazy bailout. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix deopt point for [[ToObject]] lazy bailout. This fixes the deoptimization information for the lazy bailout point after a [[ToObject]] operation inserted for with statements. The result value was pushed on the operand stack but erroneously ignored and left on the operand stack by the FullCodeGenerator. R=jarin@chromium.org TEST=mjsunit/regress/regress-5205 BUG=v8:5205 Committed: https://crrev.com/a95cdbb4b490fcab835347836dbb3ac4864789af Cr-Commit-Position: refs/heads/master@{#37818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-5205.js View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-15 14:12:22 UTC) #2
Jarin
lgtm
4 years, 5 months ago (2016-07-15 17:19:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158443002/1
4 years, 5 months ago (2016-07-18 07:47:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 08:08:34 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 08:09:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a95cdbb4b490fcab835347836dbb3ac4864789af
Cr-Commit-Position: refs/heads/master@{#37818}

Powered by Google App Engine
This is Rietveld 408576698