Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 215843003: Revert of CSS Transforms: Implement transform-style (Closed)

Created:
6 years, 9 months ago by alancutter (OOO until 2018)
Modified:
6 years, 9 months ago
Reviewers:
dstockwell, eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, eseidel, esprehn, abarth-chromium, ojan, Julien - ping for review
Visibility:
Public.

Description

Revert of CSS Transforms: Implement transform-style (https://codereview.chromium.org/211123002/) Reason for revert: Breaks perf test: src/tools/perf/tough_animation_cases/transform_transition_js_block.html BUG=356859 Original issue's description: > CSS Transforms: Implement transform-style > > Implements transform-style as defined in CSS Transforms[1]. Behavior is > identical to -webkit-transform-style. > > Note, this property is guarded by the CSSTransformsUnprefixed runtime feature > (enabled only for testing). > > [1] http://www.w3.org/TR/css3-transforms/ > > BUG=154772 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170013 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170166 TBR=eseidel@chromium.org,dstockwell@chromium.org NOTREECHECKS=true NOTRY=true BUG=154772 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -57 lines) Patch
D LayoutTests/transforms/resources/parsing-test-helper.js View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/transforms/transform-style-parsing.html View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 3 chunks +1 line, -2 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
alancutter (OOO until 2018)
Created Revert of CSS Transforms: Implement transform-style
6 years, 9 months ago (2014-03-28 00:09:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/215843003/1
6 years, 9 months ago (2014-03-28 00:09:53 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 00:10:36 UTC) #3
Message was sent while issue was closed.
Change committed as 170227

Powered by Google App Engine
This is Rietveld 408576698