Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 215843002: Dispel the myth that enclosingLayer can return zero (Closed)

Created:
6 years, 9 months ago by abarth-chromium
Modified:
6 years, 9 months ago
Reviewers:
esprehn
CC:
blink-reviews, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Dispel the myth that enclosingLayer can return zero A bunch of code was needlessly null-checking enclosingLayer. That function can only return zero for RenderObjects that are outside of the render tree. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -61 lines) Patch
M Source/core/events/MouseRelatedEvent.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +7 lines, -8 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +9 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 4 chunks +22 lines, -33 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 9 months ago (2014-03-27 23:49:50 UTC) #1
esprehn
lgtm, but perhaps enclosingLayer() should return a reference and ASSERT() you're in the tree?
6 years, 9 months ago (2014-03-27 23:51:19 UTC) #2
abarth-chromium
On 2014/03/27 23:51:19, esprehn wrote: > lgtm, but perhaps enclosingLayer() should return a reference and ...
6 years, 9 months ago (2014-03-28 00:10:04 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-28 00:10:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/215843002/1
6 years, 9 months ago (2014-03-28 00:11:04 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 00:58:15 UTC) #6
Message was sent while issue was closed.
Change committed as 170233

Powered by Google App Engine
This is Rietveld 408576698