Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2158423003: Remove DISALLOW_COPY_AND_ASSIGN from MinidumpStreamInfo (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 5 months ago
Reviewers:
ivanpe, Will Harris
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove DISALLOW_COPY_AND_ASSIGN from MinidumpStreamInfo DISALLOW_COPY_AND_ASSIGN was inadvertently added to Minidump::MinidumpStreamInfo in f04a010f71f6, but this class is used as the value side of the Minidump::stream_map_ map and must be copyable (with an old enough C++ library). This broke: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/247141/steps/compile%20%28with%20patch%29/logs/stdio TBR=ivanpe@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/5f638d532312685548d5033618c8a36f73302d0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/google_breakpad/processor/minidump.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mark Mentovai
I’m committing this TBR because Ivan’s away and it’s a simple build fix to unblock ...
4 years, 5 months ago (2016-07-20 14:08:07 UTC) #3
Mark Mentovai
Committed patchset #1 (id:1) manually as 5f638d532312685548d5033618c8a36f73302d0a (presubmit successful).
4 years, 5 months ago (2016-07-20 14:08:21 UTC) #5
Will Harris
lgtm fwiw :)
4 years, 5 months ago (2016-07-20 14:12:58 UTC) #6
ivanpe
4 years, 5 months ago (2016-07-23 00:14:42 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698