Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py

Issue 2158413003: Parameters to significantly_different.py need to be parsed as lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py b/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py
index 2c8da3cc0c4404c9f442299ebf5a79b39449428e..346c90f2d1c10591a575c15dba0a40644c723583 100755
--- a/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py
+++ b/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py
@@ -34,5 +34,17 @@ class SignificantlyDifferentTest(unittest.TestCase):
0.40073980338363635,
results['mann_p_value'])
+ def test_single_value(self):
+ try:
+ results = significantly_different.main(
+ ['', '[1, 1, 1, 1, 1, 1]', '[1, 1, 1]', '0.05'],
+ self.conda_path)
+ self.assertIsNone(results['mann_p_value'])
+ self.assertFalse(results['significantly_different'])
+ except significantly_different.ScipyNotInstalledError:
+ # This is meant to let presubmit pass on CQ bots :( because they don't
+ # have scipy either directly or thorugh anaconda.
+ return
+
if __name__ == '__main__':
unittest.main()

Powered by Google App Engine
This is Rietveld 408576698